DataViews: remove unused .dataviews-view-table__cell-content-wrapper:empty style rule
#65084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
oandregal
commented
Sep 5, 2024
| @@ -132,6 +132,9 @@ | |||
| display: flex; | |||
| align-items: center; | |||
| } | |||
| .dataviews-view-table__cell-content-wrapper:empty { | |||
There was a problem hiding this comment.
@jameskoster How should I test this is working properly? I couldn't do a proper git blame to understand where this rule comes from due to files being moved around, so I presume you'd know something about this :)
There was a problem hiding this comment.
My understanding is that we're trying to ignore this cell from layout calculation. However, without this rule: its column's width is still going to be as wide as the table header; its row's height would use the tallest adjacent cell; and the related flex properties this overrides wouldn't be applied anyway? Struggling a bit to see when this would be important.
There was a problem hiding this comment.
I'm afraid I don't exactly remember. I agree it doesn't seem to serve a purpose which suggest it relates to part of the UI that has evolved over time.
Since it hasn't been working for a while, and doesn't seem to affect anything maybe it's safe to remove?
There was a problem hiding this comment.
Yeah, it makes more sense. Pushed the removal.
|
Size Change: -427 B (-0.02%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
oandregal
changed the title
.dataviews-view-table__cell-content-wrapper:empty style rule.dataviews-view-table__cell-content-wrapper:empty style rule
jameskoster
approved these changes
Sep 5, 2024
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on other things, I've noticed the
.dataviews-view-table__cell-content-wrapper:emptystyle rule was always discarded because the default rule had higher priority.This removes the rule as it doesn't serve any purpose.