@wordpress/components: add local copy of use-lilius
#65097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @its-danny. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Code Quality
|
cc @its-danny |
|
Size Change: -500 B (-0.03%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Sep 5, 2024
|
Do we know what "lilius" actually means? 🙂 Maybe we should rename it to something less poetic like |
|
@jsnajdr it's just a reference to this guy; |
|
No strong preferences on the hook name on my side, we can go with whatever folks prefer. |
mirka
approved these changes
Sep 5, 2024
DaniGuardiola
approved these changes
Sep 6, 2024
t-hamano
reviewed
Sep 6, 2024
t-hamano
approved these changes
Sep 6, 2024
ciampo
force-pushed
the
feat/components/use-lilius-local-copy
branch
from
1ede250
to
903ab49
Compare
|
Thank you for the reviews! Let's keep |
|
Thanks for taking it home, folks, and especially @its-danny for reaching out proactively 🙌 |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use a local copy of the
use-liliuslibrary, instead of consuming the npm dependencyWhy?
As discussed in #64968 (reply in thread), the
use-liliusthird-party library is no longer maintained, and we decided to keep a local copy of it.How?
package-lock.jsonTesting Instructions
DateTime-related components work as before