Block Bindings: Add styles for attribute panel read only state #65103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
artemiomorales
requested review from
gziolo,
SantosGuillamot,
jasmussen and
cbravobernal
and removed request for
tellthemachines
artemiomorales
added
[Type] Enhancement
|
@jasmussen Just changing the text color may be too subtle. Do you think there's anything else we should do to signal when the attributes panel is read only? |
|
Size Change: +14 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a073f8e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10728847281
|
|
This is the difference I see. Admin:
Editor:
Removing the interactivity and ellipsis helps. I agree just changing the color doesn't add much. Do we need it? If we need to disable the button, it should actually look disabled. And for disabled buttons, there are no contrast requirements, so in principle you could add something like Another option would be to apply the $gray-100 color as a background color on the item. |
I was thinking about that as well. Putting the |
I agree that changing the color doesn't add too much value. I would personally lean towards:
|
|
Not doing anything can always serve as a starting point. Here's what the gray background would do:
Not helping either, and there's still a white border glitch at the bottom of the itemgroup component. |
I don't know how viable it is to tap into the |
Ok, I'm hearing that... Am I getting that right? If so, we can close this PR and issue for now and see what the feedback is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, only admins can create and modify bindings using the attributes panel, whereas for editors the panel is in a read only state. We do not distinguish between these two modes, so this PR adds styling to distinguish when the attributes panel is non-interactive.
Why?
Addresses #65093
We want to signal when the attributes panel is read only so users don't perceive that as a bug.
How?
It sets the attribute name to gray in the panel.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After