Add prompt for drag and drop in Patterns tab in Zoom Out mode #65115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +176 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aa70586. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10774088900
|
|
Design wise, it's not quite on. Perhaps @WordPress/gutenberg-design can do a quick pass. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mtias
added
Needs Design
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
I think we can drop the icon |
|
I'd echo that. I'd use the same 12px helper-text font size we use for other help text. Can be gray-900 to ensure contrast. |
✅ Done 
|
|
Looks good, except we need to deal with that typographic widow. The
Noting that Safari doesn't support |
|
Ok I've updated
There is no named font size setting in 
|
|
Looks good! |
scruffian
reviewed
Sep 9, 2024
| <VStack spacing={ 4 }> | ||
| { currentCategoryPatterns.length > 0 && ( | ||
| <> | ||
| { isZoomOutMode && ( |
There was a problem hiding this comment.
Do we only want the prompt in zoom out mode?
There was a problem hiding this comment.
If this looks like a useful information addition we should add it in general to the patterns tab.
scruffian
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Code wise this looks good.
To be honest I'm not sold on the experience. I feel like drag and drop is a primitive affordance in Gutenberg and this feels like a strange place to teach users about it, but don't let that block this PR.
An alternative idea could be to add a reminder about drag and drop to the snackbar, when a pattern is inserted via a click rather than drag and drop.
|
Let's try it. Revert is super simple on this one. |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a small prompt to the Patterns inserter when in Zoom Out mode to encourage users to try drag and drop.
Why?
Currently it's not obviously that drag and drop is enabled. This is one option to encourage that.
How?
Add text.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast