Fix: Moving a page to the trash on the site editor does not goes back to the pages list #65119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Sep 6, 2024
| isDeleting: store.isDeletingPost(), | ||
| postId: store.getCurrentPostId(), | ||
| title: store.getCurrentPostAttribute( 'title' ), | ||
| item: store.getCurrentPost(), |
There was a problem hiding this comment.
Can we avoid calling the selector here which triggers a pre-rendering on each range and only call getCurrentPost within the callback.
There was a problem hiding this comment.
Hi @youknowriad good catch, the suggestion was applied.
|
Size Change: -5 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/moving-a-page-to-the-trash-on-the-site-editor-does-goes-back-to-the-pages-list
branch
from
481bc58
to
8c6da6e
Compare
|
The |
Hi @Mamaduka, thank you for the review, I removed the trash handling from it as suggested. |
Mamaduka
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Thank you, @jorgefilipecosta! The updates work as expected ✅
There's a small error in BrowserURL unit test file that needs to be fixed.
/home/runner/work/gutenberg/gutenberg/packages/edit-post/src/components/browser-url/test/index.js
[2] 9:26 error 'getPostTrashedURL' is defined but never used no-unused-vars
|
Do we have an e2e test about this flow? Would be a good addition if not. |
jorgefilipecosta
force-pushed
the
fix/moving-a-page-to-the-trash-on-the-site-editor-does-goes-back-to-the-pages-list
branch
from
2a10201
to
28ba06b
Compare
jorgefilipecosta
deleted the
fix/moving-a-page-to-the-trash-on-the-site-editor-does-goes-back-to-the-pages-list
branch
We don't have an e2e test for this flow I will look into implementing one. |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #65087 we restored the move to trash button. But with the sidebar unification between the edit post and edit site that means the move to trash button is now also available on the edit site.
On the edit site, we have an issue where if we move a page to the trash the page is moved to trash but for the user, it seems like nothing happened as the editor keeps open on that page. And the move to trash button is still available, which is confusing.
This PR fixes the issue by calling onActionPerformed with the move-to-trash action after the post is moved to the trash, this ensures the expected behavior after a post is trashed happens no matter if the user is on the site editor or the post editor.
cc: @youknowriad, @Mamaduka as code reviewers of the related pull request.
Testing Instructions
Opened the site editor, and went to the pages section.
Opened a page in the editor, moved the page to the trash, and verified the UI was moved to the pages list (on the trunk it keeps the page opened as if nothing happened).