-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zoom Out toggle to editor header when experiment enabled #65183
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
12a3d2a
Add toggle when experiment active
getdave a8fdd5d
Add new square icon
getdave 782cee9
Use new icon
getdave ee124de
Remove zoom out desktop 50% from device preview dropdown
jeryj 3b14f3a
Fix console error for stroke-width to strokeWidth
jeryj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { Button } from '@wordpress/components'; | ||
import { __ } from '@wordpress/i18n'; | ||
|
||
import { useDispatch, useSelect } from '@wordpress/data'; | ||
import { store as blockEditorStore } from '@wordpress/block-editor'; | ||
import { square as zoomOutIcon } from '@wordpress/icons'; | ||
|
||
const ZoomOutToggle = () => { | ||
const { isZoomOutMode } = useSelect( ( select ) => ( { | ||
isZoomOutMode: | ||
select( blockEditorStore ).__unstableGetEditorMode() === 'zoom-out', | ||
} ) ); | ||
|
||
const { __unstableSetEditorMode } = useDispatch( blockEditorStore ); | ||
|
||
const handleZoomOut = () => { | ||
__unstableSetEditorMode( isZoomOutMode ? 'edit' : 'zoom-out' ); | ||
}; | ||
|
||
return ( | ||
<Button | ||
onClick={ handleZoomOut } | ||
icon={ zoomOutIcon } | ||
label={ __( 'Toggle Zoom Out' ) } | ||
isPressed={ isZoomOutMode } | ||
size="compact" | ||
/> | ||
); | ||
}; | ||
|
||
export default ZoomOutToggle; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { SVG, Path } from '@wordpress/primitives'; | ||
|
||
const square = ( | ||
<SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none"> | ||
<Path | ||
fill="none" | ||
d="M5.75 12.75V18.25H11.25M12.75 5.75H18.25V11.25" | ||
stroke="currentColor" | ||
strokeWidth="1.5" | ||
strokeLinecap="square" | ||
/> | ||
</SVG> | ||
); | ||
|
||
export default square; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will currently appear across all editors.
If instead we only want it on the Site Editor then we can use the
<PinnedItems.Slot scope="core" />
to add the Toggle.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, it's still behind the flag.