Remove colons from control labels #65205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
mirka
commented
Sep 10, 2024
| @@ -53,7 +53,7 @@ export default function ArchivesEdit( { attributes, setAttributes } ) { | |||
| <SelectControl | |||
| __next40pxDefaultSize | |||
| __nextHasNoMarginBottom | |||
| label={ __( 'Group by:' ) } | |||
| label={ __( 'Group by' ) } | |||
| @@ -243,7 +243,7 @@ export default function LatestPostsEdit( { attributes, setAttributes } ) { | |||
| { displayPostContent && ( | |||
| <RadioControl | |||
| className="wp-block-latest-posts__post-content-radio" | |||
| label={ __( 'Show:' ) } | |||
| label={ __( 'Show' ) } | |||
| @@ -29,7 +29,7 @@ export default function WidgetTypeSelector( { selectedId, onSelect } ) { | |||
| <SelectControl | |||
| __next40pxDefaultSize | |||
| __nextHasNoMarginBottom | |||
| label={ __( 'Select a legacy widget to display:' ) } | |||
| label={ __( 'Legacy widget to display' ) } | |||
There was a problem hiding this comment.
To test, install and enable a legacy theme like Twenty Twelve. Go to wp-admin/widgets.php, and insert a Legacy Widget block into one of the sections.
| Before | After |
|---|---|
No strong opinion about the label text — I think it could be as short as "Legacy widget".
There was a problem hiding this comment.
The shorter one makes sense to me; however, note that if we change the string too much, GlotPress will drop existing translations and will no longer consider them "fuzzy." By default, if half the string is the same, its translations will be kept and marked as fuzzy:
With that in mind, what you changed should help keep the string. If you change it to "Legacy widget", the translations will be dropped and the string will have to be re-translated. This might be what you essentially expect, but I just wanted to confirm.
There was a problem hiding this comment.
I think "Legacy widget" is much better. Could we maybe ping someone in the translation community to take care of it after merged?
There was a problem hiding this comment.
Translations are a shared responsibility, thousands of folks translate into all languages, and the string will need to just be re-translated in all languages. Not a huge deal, it's happened before. Just feels like something that's not part of the PR's goal and will cause an unintended side effect (losing the existing translations).
There was a problem hiding this comment.
Interesting, I wasn't thinking about translations! I'm not super familiar with the i18n system, but since there already is a "Legacy widget" string within the same project, I would assume that it would just reuse that? @tyxla Do you happen to know if there are any quirks here?
There was a problem hiding this comment.
Ah, didn't realize we're using that string already. It appears like it should work! It would only be an issue if the meaning of the string in the two separate contexts is not the same. Looks like it should be OK though 👍
There was a problem hiding this comment.
Perfect, let's go with the shorter one then.
mirka
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -11.7 kB (-0.66%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 10, 2024
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes any trailing colons in the labels of control components.
Why?
When doing consistency work across the core blocks, I noticed that there are some blocks that have a trailing colon in the label of some of their controls. These are unnecessary and goes against the labeling style of everything else. (This should probably be part of a style guide — cc @mattrwalker @WordPress/gutenberg-design)
Testing Instructions
See inline comments.