Disallow setting grid block rows/columns to zero #65217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Sep 10, 2024
| @@ -74,7 +74,8 @@ export default { | |||
| // In the experiment we want to also show column control in Auto mode, and | |||
| // the minimum width control in Manual mode. | |||
| const showColumnsControl = | |||
| window.__experimentalEnableGridInteractivity || layout?.columnCount; | |||
| window.__experimentalEnableGridInteractivity || | |||
| !! layout?.columnCount; | |||
There was a problem hiding this comment.
This is what was incorrectly causing 0 to be rendered
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Nice simple fix, this is testing well for me and makes sense that you can't set 0 columns in the UI. Folks can still switch back to Auto mode manually via the toggle, so it doesn't feel like an issue to me if people can no longer set 0 manually via the input field to toggle back to Auto — I doubt anyone would really reach to do that anyway.
LGTM! 🚀
|
Thanks for the quick fix! |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65201, by ensuring
0isn't incorrectly output and then further not allowing a zero value for grid or row counts.Why?
IMO, a value of zero doesn't really make sense for grid block columns or rows, I'm not sure what purpose it would have, so I've added some code to disallow it. This also ensures the UI doesn't surprisingly switch between Manual and Auto without the user explicitly setting it.
How?
onChangeto prevent0from being typed in.Testing Instructions
Screenshots or screencast
Before
After