-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combobox Control: Add placeholder attribute #65254
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This will address part of #37011 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall 👍 Thanks @zaguiini!
I've left a couple of minor suggestions.
Also the PR could use a CHANGELOG entry.
packages/components/src/combobox-control/stories/index.story.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 🚀
4f03730
to
12e67c6
Compare
What?
Title.
Why?
Increase UX of the Combobox control by making possible to specify a placeholder for it.
How?
Accepts a
placeholder
prop and passes it to the<TokenInput />
element.Testing Instructions
Open Storybook and pick the Components > ComboboxControl component. You should see the placeholder applied.
Screenshots or screencast