Make wordpress/fields a private package
#65269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
the
[Type] New API
gziolo
reviewed
Sep 12, 2024
There was a problem hiding this comment.
It is also worth noting that packages marked as public are automatically picked by the developer portal:
https://developer.wordpress.org/block-editor/reference-guides/packages/packages-fields/
You probably will have to run npm run docs:build to update the manifest for the portal. However, the page will be there but possible not listed in the sidebar anymore.
oandregal
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
gziolo
approved these changes
Sep 12, 2024
|
Thank you for a follow-up on this one. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Flaky tests detected in d4e5c0b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10828407097
|
noisysocks
added a commit
that referenced
this pull request
Sep 19, 2024
This reverts commit 1a60dff.
gziolo
added a commit
that referenced
this pull request
Sep 19, 2024
This reverts commit 1a60dff. Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
This reverts commit 1a60dff. Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #65230 (comment)
Makes the
fieldpackage a private one, until it's used by core.