-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Replace sprintf-js
with @tannin/sprintf
#65273
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There is something wrong with types so I can't use quickly CI to calculate bundle size change for
|
I pushed a few fixes that should get this building. |
Size Change: -242 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
FYI @sgomes - looking at slimming down the i18n package. |
@@ -93,7 +93,8 @@ | |||
"@wordpress/viewport": "file:packages/viewport", | |||
"@wordpress/warning": "file:packages/warning", | |||
"@wordpress/widgets": "file:packages/widgets", | |||
"@wordpress/wordcount": "file:packages/wordcount" | |||
"@wordpress/wordcount": "file:packages/wordcount", | |||
"@tannin/sprintf": "1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: alphabetical order
I'm trying to get some data on what plugins or themes might be using this, but it's tricky. Here's an attempt at searching plugins for sprintf patterns that aren't supported by tannin's sprintf. Most of the results seem to be false positives either from PHP or minified JavaScript. |
What?
Experiment for:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast