Switch from UglifyJS to Terser to build the polyfill script #65278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -29 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c8e19cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10829344381
|
tyxla
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Looks good ✅
Fixed core-js comment is there as expected:
Any default terser settings differ from the uglifyjs ones? Maybe it's worth checking.
I'm not sure if and how this script is ran during Gutenberg build. Maybe only Core builds the polyfill?
Yes it is. It's part of wp-scripts build / wp-scripts start. See:
and:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@tyxla what you're linking to are usages of the Babel preset. I.e., the |
Hmm yes, you're right. I don't see an immediate direct usage of the script itself. Maybe the script was there solely to quickly test the package functionality, like we did for this PR. |
I finally found how it's used:
|
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack and other tools switched from UglifyJS to Terser several years ago, but our script for bundling the
polyfillscript still uses UglifyJS. This PR switches to latest version of Terser.Terser-minified files are around 1% bigger that uglified ones. I've seen this elsewhere, too. But I guess it's worth using the same minifier consistently.
I fixed the condition that preserves license comments to also catch a lowercase
"license"string. Then the minifiedpolyfill.min.jshas a license comment at the beginning.How to test:
cd packages/babel-preset-defaultand runnpm run build. The build files are in the package's./buildsubfolder.I'm not sure if and how this script is ran during Gutenberg build. Maybe only Core builds the polyfill?