Swap position of the Pre-publish checks buttons. #65317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.08 kB (+0.06%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Animated GIFs before and after: Before:
After:
|
|
Seems good to me. Also aligns with the button order in modals, and in page headers (like data views) if/when secondary actions are added. |
|
@jameskoster thanks for your review. |
youknowriad
approved these changes
Sep 19, 2024
| this.cancelButtonNode = createRef(); | ||
| } | ||
|
|
||
| componentDidMount() { |
There was a problem hiding this comment.
Unrelated: Haha, looks like these are very old components, some of the few that are still using the component class. Unrelated, but we should refactor this.
There was a problem hiding this comment.
Yeah I did notice that.
There was a problem hiding this comment.
Wow, I haven't seen a componentDidMount in a while 😂
There was a problem hiding this comment.
45 occurrences of componentDidMount() in the current codebase 😉
noisysocks
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Swap position of the Pre-publish checks buttons. * Adjust test. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 2d3a8bd |
noisysocks
added
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/19.3 branch to get it included in the next release: 88836f0 |
kevin940726
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Swap position of the Pre-publish checks buttons. * Adjust test. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
kevin940726
removed
the
Backport to Gutenberg RC
|
Much appreciated. Thanks! |
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
|
thank youuuuuuuuuuuuuuu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65315
What?
Avoids users to unnecessarily move their mouse when publishng. This way, a two quick mouse clicks are way easier to perform in order to publish without having to move the mouse.
Why?
Forcing users to move their pointing device (mouse, trackpad, etc.) to be able to click the second Publish button in the Pre-publish checks panel isn't a great user experience.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After:
Swapped buttons when scheduling and submitting for review: