Editor: Use hooks instead of HoC in BlockManager
#65349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
t-hamano
commented
Sep 14, 2024
| showBlockTypes( blockNames ); | ||
| } | ||
|
|
||
| const filteredBlockTypes = useMemo( () => { |
There was a problem hiding this comment.
I have taken this comment into account and cached the results, but is this a good idea?
There was a problem hiding this comment.
The original comment concerns returning a new array reference from the mapSelect callback. This would result in a rerender every time the block store is updated and a warning from useSelect in dev mode.
It should be okay to leave it without memoization. But don't have a strong opinion here.
There was a problem hiding this comment.
I see. Just to be safe, I would like to remove useMemo and then merge.
|
Size Change: -35 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the
BlockManagercomponent to use hooks.Why?
Optimization. This is also preparation for moving forward with #62703.
Testing Instructions
Open the Preferences modal and go to the section "Manage block visibility".
Note: It should be easier to confirm if you test it after opening the block inserter.
Screenshots or screencast
90749cade18aa93f28638e09542c2f5a.mp4