Post Content Block: Fix conflict between clearFix and focus ring in the editor #65364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -28 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I'm adding this PR to the project board because it addresses an issue that first appeared in WP 6.7. |
t-hamano
force-pushed
the
post-content-clearfix
branch
from
c22a4ef
to
b355273
Compare
kevin940726
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Works well for me! I also tested the original steps in #63690 and it still worked. 💯
|
@kevin940726 Thanks for the review! Just to be safe, I will rebase this PR, retest it and then merge it. |
t-hamano
force-pushed
the
post-content-clearfix
branch
from
b355273
to
64bd80e
Compare
|
@kevin940726 Is it ok to backport this PR to WP 6.7? Because the problem this PR is trying to solve first appeared in WP 6.7. |
andrewserong
added
the
Backport to WP 6.7 Beta/RC
I'm not @kevin940726 😄, but this sounds reasonable to me! I've added the label so that it'll try to auto-cherry pick once this PR lands. |
|
I don't see why not! Thank you @andrewserong for labelling it! |
|
This looks good to go 👍 |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 7, 2024
…he editor (#65364) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b4dd404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatives to #63690
What?
This PR restores the focus ring in the editor by taking a different approach to solving the issue of left- and right-aligned blocks overflowing their content area.
Why?
#63690 added a clearfix (
::afterpseudo-element) to the Post Content block to fix overflow issues. In the editor, the::afterpseudo-element is used as a focus ring when the block is selected, causing conflicts.How?
Use
display: flow-rootinstead of theclearfix. This style determines how to handle floated items in a container and should be equivalent to theclearfix. This CSS is supported in major browsers: https://caniuse.com/flow-rootTesting Instructions
Screenshots or screen
Before
After