Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button Replace remaining 40px default size violations [Edit widgets] #65367

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix: Button Replace remaining 40px default size violations [Edit widgets] #65367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/edit-widgets/src/components/error-boundary/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,7 @@ import { doAction } from '@wordpress/hooks';
function CopyButton( { text, children } ) {
const ref = useCopyToClipboard( text );
return (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
variant="secondary"
ref={ ref }
>
<Button __next40pxDefaultSize variant="secondary" ref={ ref }>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
before-copy-error

After
after-copy-error

{ children }
</Button>
);
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-widgets/src/components/secondary-sidebar/inserter-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ export default function InserterSidebar() {
>
<TagName className="edit-widgets-layout__inserter-panel-header">
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
before-widget-insert

After
after-widget-insert

icon={ close }
onClick={ closeInserter }
label={ __( 'Close block inserter' ) }
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-widgets/src/components/secondary-sidebar/list-view-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ export default function ListViewSidebar() {
<div className="edit-widgets-editor__list-view-panel-header">
<strong>{ __( 'List View' ) }</strong>
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
before-list-view
After
after-list-view

icon={ closeSmall }
label={ __( 'Close' ) }
onClick={ closeListView }
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-widgets/src/components/sidebar/widget-areas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ export default function WidgetAreas( { selectedWidgetAreaId } ) {
) }
{ ! selectedWidgetArea && (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
before-widget-area

After
after-widget-area

href={ addQueryArgs( 'customize.php', {
'autofocus[panel]': 'widgets',
return: window.location.pathname,
Expand Down
Loading