Dataviews config dropdown: remove style overrides #65373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Enhancement
|
Size Change: +52 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
reviewed
Sep 16, 2024
packages/dataviews/src/components/dataviews-view-config/index.tsx
Outdated
Show resolved
Hide resolved
packages/dataviews/src/components/dataviews-view-config/index.tsx
Outdated
Show resolved
Hide resolved
tyxla
reviewed
Sep 17, 2024
packages/dataviews/src/components/dataviews-view-config/index.tsx
Outdated
Show resolved
Hide resolved
packages/dataviews/src/components/dataviews-view-config/index.tsx
Outdated
Show resolved
Hide resolved
ciampo
force-pushed
the
fix/dataviews-config-dialog-dropdown-layout
branch
from
f6aa642
to
4f5d429
Compare
|
Rebased on top of latest trunk, and addressed all feedback. |
tyxla
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #65314
Remove style overrides from Dataviews config dropdown
Why?
Style overrides (especially the ones using internal component classnames) should be avoided as much as possible
How?
Use the
DropdownContentWrappercomponent insteadTesting Instructions
Screenshots or screencast