Use custom block name in inspector controls when available #65398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +44 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
This comment was marked as resolved.
This comment was marked as resolved.
|
@t-hamano localising the block title (Group, Paragraph, etc) makes sense, but since the name is user-generated why would it need to be localised? |
The localization here is intended to localize the parentheses, not the block name. Because we're not sure if parentheses are appropriate in all languages. |
|
Derp, of course. Ignore me :D |
talldan
approved these changes
Sep 18, 2024
|
@jameskoster Took a look and didn't object so I'm going to merge this. Thanks for review folks 🙇 |
|
It's fine having the name in the Inspector, but I think the block's title It's just as disorienting having different labels for both placements, and is not particularly helpful reading the block title. I propose we follow up by removing the block title.
|
@richtabor PR to resolve this https://github.com/WordPress/gutenberg/pull/65641/files |
This was referenced Sep 26, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Uses the custom name for a block in the block inspector controls when set.
Why?
The list view shows the custom name of the block but this isn't reflected in the inspector controls. It's helpful to have this affordance made consistent.
How?
Shows any
attributes.metadata.namein the inspector controlsBlockCardwhen available.I did consider amending the lower level
useBlockDisplayInformationto make this part oftitleif available, butnameis already exposed on that hook so it seems better to just use that directly as required.Testing Instructions
Renameand provide a custom name{Custom name} (Group).Testing Instructions for Keyboard
Screenshots or screencast