Block Bindings: Improve getRegisteredPostMeta resolver #65450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Code Quality
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
commented
Sep 18, 2024
Comment on lines
+996
to
+1011
| let options; | ||
| try { | ||
| const { | ||
| rest_namespace: restNamespace = 'wp/v2', | ||
| rest_base: restBase, | ||
| } = ( await resolveSelect.getPostType( postType ) ) || {}; | ||
| const options = await apiFetch( { | ||
| options = await apiFetch( { | ||
| path: `${ restNamespace }/${ restBase }/?context=edit`, | ||
| method: 'OPTIONS', | ||
| } ); | ||
| } catch ( error ) { | ||
| // Do nothing if the request comes back with an API error. | ||
| return; | ||
| } | ||
|
|
||
| if ( options ) { |
SantosGuillamot
commented
Sep 18, 2024
| @@ -47,7 +47,7 @@ export interface State { | |||
| navigationFallbackId: EntityRecordKey; | |||
| userPatternCategories: Array< UserPatternCategory >; | |||
| defaultTemplates: Record< string, string >; | |||
| registeredPostMeta: Record< string, { postType: string } >; | |||
| registeredPostMeta: Record< string, Object >; | |||
There was a problem hiding this comment.
I wasn't sure if Object is enough or we should specify the properties. Those properties might change in the future if the REST API schema changes, and that seems unrelated to this part of the code. That's why ended up using just Object.
Additionally, the other similar resolvers use the same.
|
Size Change: -5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Sep 18, 2024
SantosGuillamot
deleted the
update/improve-get-registered-post-meta-resolver
branch
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR covers two points reported here:
falsewhen there is an error.Why?
It doesn't seem right at the moment.
How?
For handling the error, I followed a similar approach to other resolvers like this one, this one, or this one.
Additionally, I updated the second parameter of Record to be
Object.Testing Instructions
Everything should keep working as expected and e2e tests should pass.