Avatar: Add block example #65509
Merged
Avatar: Add block example #65509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #64707
Related: #65430
What?
Adds a simple example for the Avatar block.
Why?
The Style Book is being iterated on and part of that effort is to ensure the desired blocks are shown there. Currently this is dependent on blocks having an example defined.
How?
Adds the simplest example possible for the block.
Alternatives
The Avatar block renders a placeholder when it doesn't have a user with avatar assigned. It might be a better experience to retrieve the current user and use that in the block example.
To be able to achieve this a custom static example might be required in the Style Book. Additionally, it might also still be desirable to see the placeholder state. Perhaps a future iteration could be to define a custom example that actually renders two Avatar blocks, one with a gravatar and one in the placeholder.
Testing Instructions
Screenshots or screencast