Select Mode: Blocks outside the main sections root should be disabled #65518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
youknowriad
requested review from
draganescu,
getdave,
noisysocks,
talldan and
jameskoster
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +41 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
reviewed
Sep 20, 2024
Comment on lines
+2996
to
+3001
| // Blocks outside sections should be disabled. | ||
| const isWithinSectionRoot = isWithinBlock( | ||
| state, | ||
| clientId, | ||
| sectionRootClientId | ||
| ); |
There was a problem hiding this comment.
Do we also want to do this in zoom-out mode? I'd say we might well.
Aside: this is why maintaining x2 similar modes during the 6.7 release cycle is going to be tricky.
There was a problem hiding this comment.
What if we just change the condition to if [ "zoom-out", "navigation" ].includes( editorMode ) (until we remove zoom-out)
There was a problem hiding this comment.
Here are the two differences that exist with zoom-out today:
- The root container is "default" in "navigation" but "contentOnly" in zoom-out.
- Zoom-out doesn't enable "content blocks", everything is disabled within sections.
Do we want to unify that?
There was a problem hiding this comment.
Given that currently zoom-out disables everything that is not a section, the bug covered by this PR is actually already covered by "zoom-out" but if we change zoom-out to enable editing "content " blocks, then we'll have the same issue. So for now, it seems safe to move forward.
|
I think Zoom Out has a similar requirement. In #65145 the reporter is noting that blocks outside the section root aren't editable. |
draganescu
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #60021
What?
I noticed a bug where sometimes in "select mode" some random content blocks remain editable even if they don't belong in the "main" section. For instance in 2024, you can see that you can check the text of some menu items in the footer while editing the home page template in select mode.
This bug led me to do a small refactoring to the
getBlockEditingModefunction, added some comments and also added unit tests to cover all the "navigation mode" use-cases.Testing Instructions
1- Open 2024 home page template
2- Pick the "select tool" (or edit mode)
3- Check that you can't edit random text in the footer.