Global Styles: remove navigator screen overrides #65522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -52 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 618d16a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10958823100
|
jameskoster
approved these changes
Sep 20, 2024
|
Due to this PR, it seems that there are cases where an unintended vertical scrollbar is displayed. Is there a way to avoid this?
Please see #65825. |
|
I'll comment directly on that issue |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Requirement for #64777
Remove
Navigatorstyle overrides in the global styles sidebarWhy?
Style overrides can break the functionality of the component.
How?
Deleting styles
Testing Instructions
Interact with the global styles sidebar, make sure animations and scrolling work as expected.
Screenshots or screencast
Kapture.2024-09-20.at.13.59.23.mp4
Kapture.2024-09-20.at.14.01.30.mp4