Pages: fix featured image appearance in list layout #65525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Bug
jameskoster
added
the
Backport to WP 6.7 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +208 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 20, 2024
| @@ -138,6 +138,10 @@ ul.dataviews-view-list { | |||
| background-color: $gray-100; | |||
| border-radius: $grid-unit-05; | |||
|
|
|||
| .fields-controls__featured-image-container { | |||
There was a problem hiding this comment.
This is a field specific style, it should live where the field is defined and not in the generic dataviews package.
There was a problem hiding this comment.
Thank you. Would that be packages/edit-site/src/components/post-list/style.scss? A new stylesheet in /packages/edit-site/src/components/post-fields? Or somewhere else?
There was a problem hiding this comment.
A new stylesheet in /packages/edit-site/src/components/post-fields?
I think that would be ideal.
youknowriad
reviewed
Sep 20, 2024
| @@ -0,0 +1,3 @@ | |||
| .fields-controls__featured-image-container { | |||
There was a problem hiding this comment.
Does this style work in all layouts?
youknowriad
reviewed
Sep 20, 2024
| @@ -0,0 +1,3 @@ | |||
| .fields-controls__featured-image-container { | |||
| height: 100%; | |||
| } | |||
There was a problem hiding this comment.
There's a missing new line here.
|
Ugh, I think this may actually be an issue in #64496 and not on trunk. Long week 😪 |
|
@jameskoster Does this still need to target WordPress 6.7? |
|
No. Sorry I forgot to close this one. |
kevin940726
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Featured images of certain dimensions are not appearing correctly in the Pages data view. This PR fixes it by ensuring the container fills the available space vertically.
Testing Instructions