Block Bindings: Only use canUserEditValue when setValues is defined
#65566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
approved these changes
Sep 23, 2024
|
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ad24f57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10993431241
|
|
You may use the |
I am not sure I understand what you mean here. If you refer to the UI to create and modify bindings, I believe that's different. This is to disable editing of the blocks when they are connected to a source that doesn't support it.
Yes, it should be locked when it is undefined. |
cbravobernal
deleted the
fix/dont-allow-edit-without-set-values-in-bindings
branch
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 6584230 |
kevin940726
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
|
I just cherry-picked this PR to the release/19.3 branch to get it included in the next release: ee598d0 |
kevin940726
removed
the
Backport to Gutenberg RC
This was referenced Sep 27, 2024
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a block bindings source is registered, I believe we shouldn't allow editing when
setValuesis not defined.Why?
It is confusing that users can edit the blocks but nothing will happen.
How?
Setting
canUserEditValueto undefined whensetValuesis not defined.In order to add e2e tests, we need to register custom sources in the client. This is being done as part of this other pull request, so I thought of including the test there.
Testing Instructions
andcanUserEditValuereturnstrue`.