PHP unit tests: remove WP_RUN_CORE_TESTS const

[ramonjd]

A recent update in Core caused the php tests to fail.

I asked about it here: https://core.trac.wordpress.org/ticket/61530#comment:54

I got an answer here: https://core.trac.wordpress.org/ticket/61530#comment:55

Removing the WP_RUN_CORE_TESTS constant added in #51950 will negate the check for IMPORTER_PLUGIN_FOR_TESTS, which is required for Core tests, but not Gutenberg (right now)

Testing Instructions

Stare at the PHP tests in CI and will for them to pass. 🤞🏻

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[andrewserong]

This sounds like the right fix to me! If the PHP tests pass, let's merge it.

If not, I suppose the two other options would be to see what else needs changing in GB in order for us to remove this define, or otherwise install the importer plugin within the GB tests.

Here's hoping this does the trick! 🤞

[ramonjd]

I could watch this all day:

[noisysocks]

I added the constant in #51950 to fix failing unit tests and said at the time:

A lot of these tests, I think, don't belong in Gutenberg anymore. They should have been removed when the functionality that they test were moved from Gutenberg to Core. It doesn't make sense to have tests in Gutenberg that test Core functionality.
...
I think setting WP_RUN_CORE_TESTS is all that we can do until these tests are removed.

It seems likely that this has happened since then.

So 👍 lgtm.

[github-actions]

I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 4ab648d