Flattens icon and reduces its weight #65642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
javierarce
added
[Package] Icons
|
Size Change: -5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 11e9edb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11031079156
|
|
Thanks for the cleanup 👍
I'll defer to @richtabor on this one as I believe he originally provided the icon. |
|
'square' is a curious name for this icon, should we change that or is it too late? |
I agree. I think |
|
|
|
I think so, but cc'in the WordPress 6.7 release tech leads to make sure @noisysocks @kevin940726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The current code for the square icon introduced here included a fixed
strokeWidth="1.5"and other unecessary tags likestrokeLinecap="square". When pasted on Figma, the icon displays a width of1pxinstead of1.5px, by flattening we'll have a consistent line weight.This PR flattens the icon and also reduces its weight.
Testing Instructions
squareiconScreenshots
Here is the icon in context before and after: