Block Bindings: Use registry instead of select in canUserEditValue
#65659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
SantosGuillamot
requested review from
ellatrix and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +40 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
cbravobernal
approved these changes
Sep 25, 2024
cbravobernal
deleted the
update/pass-registry-to-can-user-edit-value
branch
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 25, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: a5c346f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In this pull request, I explore the possibility of passing
registryas a prop tocanUserEditValueinstead of justselect.I'm marking it as a
bugbecause it will help solve this issue.Why?
It helps keeping consistency between other APIs like
getValues,setValues, orgetFieldsList. This also helps in cases where we want to reuse functions among those APIs. You can find an example in this pull request, where I am reusinggetPostMetaFields.How?
I'm just passing
registryand doingregistry.selectinstead ofselect.Testing Instructions
Everything should keep working and e2e should pass.