Remove user-select:text #65662
Merged
Remove user-select:text #65662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +693 B (+0.04%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
added
the
[Feature] Writing Flow
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Sep 30, 2024
|
@ellatrix looks like there are some failing e2e tests, not sure if it's related. WDYT? |
|
Wow this is an obscure bug. Great work on narrowing it down as it directly impacts on features such as Zoom Out and Edit modes. |
|
@youknowriad I knew that there was would be no functional regression, the question is if we're ok with the visual regression (I assume there is one if @jasmussen added it). |
|
Well, the question is if it reintroduces the visual artifacting that happens when you select across text blocks in Safari. If the same steps to reproduce the issue, that are outlined in #43313 still apply, then that is a problem, because it's going to be a terrible text editing experience. I can't test now, but one would hope that Safari has improved since then. |
|
I tested multi selection and I believe I don't see the issue, but you know sometimes I don't really understand what I need to test. |
|
|
Yep, seeing the same in my Safari test. Hopefully that means it's fixed. Worth trying, but let's keep an eye on selecting across blocks in Safari post-merge! |
youknowriad
force-pushed
the
try/remove-user-select-text
branch
from
d74be84
to
a3e80aa
Compare
|
Re re re confirming this is OK :) 
|
youknowriad
force-pushed
the
try/remove-user-select-text
branch
from
a3e80aa
to
ea41fdd
Compare
|
It looks like "shift + arrow" is not working properly in this PR in Firefox, it doesn't cross the boundaries of the list block into a preceding paragraph block. |
|
@youknowriad @jasmussen the failures are caused by the disabling of text selection introduced in #58169. For some reason that's applied in the post editor too. Either we remove it or we need to find a class combo so that it's not applied in unwanted places. |
|
Tests should pass now hopefully. So only a few months ago I introduced these Firefox e2e tests. Really glad I did then, or we would have broken it now. |
|
Highly appreciated help in this PR Ella thanks a lot. |
|
Seems like it might not have solved all the "stealing focus" issues. |
|
Fix #65857 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #60021
What?
In trunk, if you have a container that is a stack or a grid block with a paragraph within it, it's very hard to select the container even if it has padding... The paragraph automatically steals focus.
It turns out that we had some CSS introduced a long time ago in #43313 to improve multi-selection styles in Safari that was responsible for this buggy behavior.
In my test, removing this CSS doesn't break the multi-selection, so this is probably not needed anymore.
Testing Instructions
1- Insert a stack block with some padding
2- Insert a paragraph within it
3- Unselect the blocks by clicking the title
4- Click the "padding" area
5- The stack should be selected and not the paragraph within it.