Block bindings: Improve performance by memo postypes slug. #65705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Feature] Block bindings
[Type] Performance
Mamaduka
reviewed
Sep 27, 2024
Comment on lines
197
to
201
| const postTypesSlugs = useMemo( () => { | ||
| return ( | ||
| postTypes?.map( ( entity ) => entity.slug ) || [] | ||
| ); | ||
| }, [] ); |
There was a problem hiding this comment.
Using hooks inside condition is against React Hook rules, and I don't think nesting useMemo calls is a good idea.
We should move postTypesSlugs map outside of current memo function.
|
Size Change: +146 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Is the PR increasing the site-editor writing a 7%?
|
It seems that specific metric varies a lot. Taking a look other random PRs: I'm more worried about
Taking a look at the PRs that got merged before that one, it seems it could affect that.
According to this data, it is a possibility that the original PR introduced a regression on this aspect. I'd like to:
Taking a look at the performance metrics from this PR, it seems the |
64 tasks
This was referenced Oct 14, 2024
|
I've opened this other pull request to potentially palliate the |
|
@SantosGuillamot, can we close this PR now that #66101 is merged? |
The biggest performance impact seems to be solved after that PR, yes. Having said that, if you think the logic in this pull request can still help, I'm fine with it. I don't have much experience with this topic, so I don't have a strong opinion. |
|
Closing in favor of #66101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the perfomance of the postTypesSlugs by memoizing it.
trunk:
PR:
