-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize typography block support keys #65964
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rinkalpagdar! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi @rinkalpagdar thanks for working on this. Are the changes to the Verse block.json just for testing purposes? |
Hello @ndiego Thanks for your feedback, Yes block.json changes are for testing purposes. |
Hello @ndiego Greetings! I have reverted to block.json changes in verse. Thanks! |
Hi @rinkalpagdar, I struggled to get this PR working properly when testing with a custom plugin. I used a simple Copyright Date block I had built in the past. The block doesn't have any experimental controls by default, so I added the following to the With experimental supports "supports": {
"color": {
"background": false,
"text": true
},
"html": false,
"typography": {
"fontSize": true,
"__experimentalFontFamily": true,
"__experimentalLetterSpacing": true
}
}, Without experimental supports "supports": {
"color": {
"background": false,
"text": true
},
"html": false,
"typography": {
"fontSize": true,
"fontFamily": true,
"letterSpacing": true
}
}, And here are the results.
As you can see, when no |
What?
Split from #63001
Why?
This issue tracks progress towards stabilizing the typography block support with backward compatibility
Stabilized the following typography block supports:
__experimentalFontFamily → fontFamily
Testing Instructions
Open block.json file or area.
If you have already used it for block support __experimentalFontFamily instead we can use it fontFamily only. Similar to other block supports as well.
Note: Here we need to update the WP core blocks' block.json files to use the non __experimental prefixes.
Screenshots or screencast