Global styles: Alphabetize items. #66172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c84ec55. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11367477382
|
t-hamano
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Personally, I lean towards keeping the current ordering.
Because when localized, it may not be alphabetical in the language. Also, there are locales that don't have an alphabet at all.
If there's something unnatural about the current ordering, how about considering sorting by meaning or importance instead of alphabetical?
|
Good points.
For one, I'd love to elevate background up higher, towards the top. |
|
I think it might be a good idea to consider the order of the block sidebar:
Taking this into consideration, one order I can think of is:
Since Layout is the base section for the entire site, I prefer it to be at the top. Do you prefer to place Background above Layout? |
|
I would move Background all the way to the top, yes, and have colors below it. Both of those are very intuitive basic ways you can customize your site appearance pretty quickly. Typography is the next most intuitive, then layout and shadows can be towards the end. |
|
So that would simply move the Background button to the top, right?
I don't have any strong preference about the order, but I'd like to hear other people's thoughts too. |
|
Yes, I'd think that's better than what ships in trunk 👍 👍 Happy to hear from others! Thank you. |
|
My feeling is that we need a larger re-organisation to group things like presets, site styles, blocks, etc. Until then I don't have a strong feeling about the order here, so I wouldn't object to moving 'Background' to the top. |
|
Do we try the approach of moving the Background to the top? Since this PR conflicts with the trunk branch, it might be a good idea to checkout again from the trunk branch, make changes, and force push. We may also want to update the PR title, description, and commit comment. |
|
Yes, I think it's easier to create a new PR for this. Unfortunately the next few days I'm unable to do this myself, but if you have bandwidth, I would appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Global styles has grown in items to the following:
That's, in order:
While there has arguably been some curation in the order of these, given recent additions, it's not clearly curated anymore. Especially if additional items were to be added, it would feel increasingly random. This PR alphabetizes:
This is slightly more predictable as far as scanning the page for a particular item.
Testing Instructions
Open the site editor, open the global styles inspector, and notice the new order of items there.