Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block toolbar: account for scrollable blocks that affect the position of the block toolbar #66188

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Block toolbar: account for scrollable blocks that affect the position of the block toolbar #66188

merged 3 commits into from
Oct 21, 2024

Commits on Oct 17, 2024

  1. The while that gets the rect bounds of the child, including the x and… 

    … y values, which change when the element is scrolled. This change attempts to correct the overflow so the scrollable children do not influence the x,y values of the popover.
    @ramonjd
    ramonjd committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9cecad1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Check for parent overflow only once.

    @ramonjd
    ramonjd committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4403bb9 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Try a mash up between code suggestions.

    @ramonjd
    ramonjd committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    218ab99 View commit details
    Browse the repository at this point in the history