Iterate zoom out shuffle into a more visual control #66194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: -346 B (-0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
update/shuffle-patterns-to-update-design
branch
from
f472bd8
to
95d620a
Compare
ntsekouras
requested review from
youknowriad,
oandregal,
jameskoster,
jasmussen and
richtabor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Quick test with a GIF:
The new text button is available only when zoomed out, which can be a good way to introduce this without necessarily touching the shuffle button. I'm happy to try this as an early aspect of 6.8. That said, outside of any other dropdown label suggestions, it should be "Change design", sentencecase rather than titlecase. |
Currently this PR removes the |
|
Should we take this as an opportunity to unify all these "switch/change/replace" flows? For clarity I'm not asking for this to be done as part of this PR necessarily, just wondering whether it makes sense and if it does, if we should do it (in steps) |
I 100% agree! |
Possibly related to this: #40208 (comment) |
Shuffle is only available in zoom out. |
No, this "Change Design" button is essentially a second iteration of the shuffle button. |
Yes. |
|
Yep, I think we should consider creating a storybook story for the |
other text toolbar buttons do not do this.
|
So I guess we agree on using
I can create a PR for that. |
|
Flaky tests detected in ce8309c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11385716360
|
|
So what's missing from this PR? Do we want to update some designs or we'll do it follow ups, consolidating the different similar lists? |
|
It would be cool if the popover was kept open, and somehow don't let it overlap with the pattern shown, so you can click around more easily. |
Perhaps if it stayed open, it could render above if there's room. A follow-up to explore? |
youknowriad
reviewed
Oct 25, 2024
| .block-editor-block-toolbar-change-design-content-wrapper { | ||
| padding: $grid-unit-15; | ||
| width: 320px; | ||
| .block-editor-block-patterns-list { |
There was a problem hiding this comment.
What's your current thoughts about absorbing this into the component with variant="grid" or something. How feasible...?
There was a problem hiding this comment.
I think it's doable (regarding the current usages and wrappers etc..). It's on my list to do this and see to consolidate the similar replace lists.
youknowriad
approved these changes
Oct 25, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #66105
This PR will update the
shufflefeature for patterns with a more visual control that shows the previews of some available patterns from the same pattern category.I commented the below in the issue:
--cc @WordPress/gutenberg-design
Currently I'm using the
BlockPatternsList- same with quick inserter.Testing Instructions
shufflebutton and in its place we render thechange designone.Screenshots or screencast
TBD