-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs and TabPanel: Fix arrow key navigation in RTL #66201
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing. Thanks 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strange thing is that the TabPanel
component (not the Tabs
component) originally worked fine with RTL languages, so removing this line doesn't seem to change the result 🤔
Do you know anything about this?
Flaky tests detected in 7de9f4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11383326372
|
Nope, no idea 🙈 But I wouldn't spend too much time on it, since the plan is to deprecate |
Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Part of #64963
Respect writing direction when using arrow keys to navigate the tabs in the
Tabs
andTabPanel
componentsWhy?
We should respect the writing direction
How?
using the
rtl
utility to detect writing direction, and passing that information to the underlying ariakit storeTesting Instructions
Tabs
andTabPanel
Screenshots or screencast
Kapture.2024-10-17.at.12.37.45.mp4
Kapture.2024-10-17.at.12.38.28.mp4