-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global styles slotfill #66282
base: trunk
Are you sure you want to change the base?
global styles slotfill #66282
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rinkalpagdar! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi @rinkalpagdar Thank you for working on this issue. |
Hello @carolinan Thanks for the feedback. Can you please suggest the name of the slot? I think the place for the slot would be great above the "browse style" . Please share your thoughts on the same. Thanks! |
Since questions remain in the original issue about whether this slot should be added, naming aside, can we add the |
I disagree, because the preview above it shows what you have selected in "Browse style", and I feel strongly that these two elements should not be separated by the slot. But this is my personal opinion. |
Hello @ndiego Thanks for the feedback. I have added the |
What?
Fixes #48068
How?
This PR introduces a new SlotFill location in the global styles section.
Testing Instructions
Screenshots or screencast