[WP 6.7] Tabs: Unify tab height to 48px/40px #66295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue discovered in this comment
What?
This PR standardizes the tab height to 48px/40px in the Tabs component.
Why?
This issue is caused by a fluid height being applied to the tabs to prevent overlapping focus styles. In #62027, the vertical padding of the tabs was changed from
3px
tospace( 4 ) = 16px
. This may cause the tab height to exceed 40px or 48px depending on the tab content.How?
All of these issues have been resolved in the trunk branch. However, since the trunk branch contains various improvements and changes, it is not possible to backport directly from the
trunk
branch to thewp/6.7
branch.As I understand it, the Tabs component expected in WP 6.7 is as follows.
To achieve these, I will submit the minimum changes to the
wp/6.7
branch.Testing Instructions
Screenshots
Horizontal tab (icon)
Horizontal tab (fluid height)
Vertical tab