[6.7] Activate zoom out only on large viewport #66330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
I made a similar change to #66308, but somehow this PR doesn't seem to dynamically reset the zoom out mode when the viewport width changes: 1a1cbc43d7327a6f86035ff65f43334b.mp4Maybe it's because the zoom out mode implementation is different between |
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
getdave
approved these changes
Oct 22, 2024
jeryj
requested changes
Oct 22, 2024
There was a problem hiding this comment.
I don't think this is the change we want. I think this should be passed in via the inserter menu boolean, not added within the useZoomOut hook.
I'm in no rush to merge if we want to explore the alternative. RC2 won't be cut until next Monday. Thanks Jerry 🙇 |
|
Based on #66341, I've updated this PR. I removed the viewport check from the useZoomOut hook and added it to the inserter menu instead. |
t-hamano
force-pushed
the
wp6.7/zoom-out-viewport
branch
from
c969b3e
to
f75b5a3
Compare
kevin940726
force-pushed
the
wp6.7/zoom-out-viewport
branch
from
c174750
to
f2b8385
Compare
|
I rebased the branch to fix the missing |
|
Flaky tests detected in f2b8385. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11511323340
|
|
@jeryj Can we get another review here please? 🙏 |
getdave
reviewed
Oct 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
jeryj
force-pushed
the
wp6.7/zoom-out-viewport
branch
from
f2b8385
to
981f386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same fix as #66308 to the
wp/6.7branchWhat?
This PR resets the zoom out mode so that the inserter doesn't get narrower on smaller viewports.
Why?
I don't think the zoomed out mode is intended for use on small viewports.
How?
There is a difference in the implementation of the
useZoomOuthook betweentrunkand thewp/6.7branch. Since we cannot backport #66308 directly, we need to manually apply the same change to thewp/6.7branch.Testing Instructions
Screenshots or screencast