Inline Commenting: Optimize store selector and misc changes #66592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Oct 30, 2024
| @@ -22,7 +22,7 @@ import { store as editorStore } from '../../store'; | |||
| import AddCommentButton from './comment-button'; | |||
| import AddCommentToolbarButton from './comment-button-toolbar'; | |||
|
|
|||
| const threadsEmptyArray = []; | |||
| const EMPTY_ARRAY = []; | |||
There was a problem hiding this comment.
This matches the name used in other places and makes it easier to search the code base.
|
Size Change: -9 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
optimize/collab-sidebar-selectors
branch
from
1e94909 to
58d03a6
Compare
ellatrix
reviewed
Oct 30, 2024
| postId: select( editorStore ).getCurrentPostId(), | ||
| postId: _postId, | ||
| postStatus: getEditedPostAttribute( 'status' ), | ||
| threads: data ?? EMPTY_ARRAY, |
There was a problem hiding this comment.
Nit: could also fall back to an array outside of the selector and we wouldn't need the constant.
There was a problem hiding this comment.
Let's leave it for now. The component seems to change more rapidly now that the general concept has landed and we have the updated designs.
ellatrix
approved these changes
Oct 30, 2024
|
Flaky tests detected in 06a1511. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11593524208
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…s#66592) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
CollabSidebarcomponent and combines store subscriptions when possible. I've also removed the side effect for settingblockCommentID.I noticed multiple
useSelecthook usages when reviewing the #66583.Why?
useSelecthooks. This reduces the number of store subscriptions.Testing Instructions
Testing Instructions for Keyboard
Same.