Move Heading block alignment settings from sidebar to block toolbar #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good and aligns nicely with the similar change to Subhead block 👍 Travis complains about PHP 5.2 targeted build, but everything looks good. Moving on regardless. |
gziolo
approved these changes
May 10, 2018
This was referenced May 10, 2018
This was referenced May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #6673 which requests the alignment settings of the "Heading" block to be moved from the sidebar to the block toolbar.
How has this been tested?
This PR has been tested by adding a "Heading" block in Gutenberg editor and locating the alignment settings of the block in the block toolbar instead of the sidebar. This was tested in WP 4.9.5, Gutenberg 2.8.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Screenshots
Types of changes
This PR removes the
AlignmentToolbarelement fromInspectorControlsand nests it insideBlockControls. The heading level controls was wrapped withToolbarfor the nesting to work.Checklist: