Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover: Fix media library image selection #66782

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Cover: Fix media library image selection #66782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87b6d60
Cover: Fix media library image selection
Mamaduka Nov 6, 2024
9b09c91
Fix sizes for uploaded images
Mamaduka Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/block-library/src/cover/edit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,24 @@ function CoverEdit( {

// Try to use the previous selected image size if it's available
// otherwise try the default image size or fallback to full size.
if ( sizeSlug && newMedia?.sizes?.[ sizeSlug ] ) {
if (
sizeSlug &&
( newMedia?.sizes?.[ sizeSlug ] ||
newMedia?.media_details?.sizes?.[ sizeSlug ] )
) {
mediaAttributes.sizeSlug = sizeSlug;
mediaAttributes.url = newMedia?.sizes?.[ sizeSlug ]?.url;
} else if ( newMedia?.sizes?.[ imageDefaultSize ] ) {
mediaAttributes.url =
newMedia?.sizes?.[ sizeSlug ]?.url ||
newMedia?.media_details?.sizes?.[ sizeSlug ]?.source_url;
} else if (
newMedia?.sizes?.[ imageDefaultSize ] ||
newMedia?.media_details?.sizes?.[ imageDefaultSize ]
) {
mediaAttributes.sizeSlug = imageDefaultSize;
mediaAttributes.url = newMedia?.sizes?.[ sizeSlug ]?.url;
mediaAttributes.url =
newMedia?.sizes?.[ imageDefaultSize ]?.url ||
newMedia?.media_details?.sizes?.[ imageDefaultSize ]
?.source_url;
} else {
mediaAttributes.sizeSlug = DEFAULT_MEDIA_SIZE_SLUG;
}
Expand Down
Loading