Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align placeholder and iIllustration states between Cover and Image blocks #66816

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

rohitmathur-7
Copy link
Contributor

@rohitmathur-7 rohitmathur-7 commented Nov 7, 2024

What?

Fixes: #66768

Why?

  • Add functionality in Cover Block for displaying the placeholder state only when selected, and the illustration state when not selected—like the Image block does so that we have consistent User Experience.

How?

  • Add Placeholder in MediaPlaceholder in Cover Block.

Testing Instructions

  • Add Cover Block in the editor.
  • Select the Cover block then we should see the placeholder state, and when Cover block is not selected then we should see the illustration state.

Screenshots or screencast

When Cover Block is Selected (Placeholder state):
Screenshot at Nov 07 16-00-35

When Cover Block is not Selected (Illustration State):
Screenshot at Nov 07 16-00-47

Copy link

github-actions bot commented Nov 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rohitmathur-7 <rohitmathur7@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align placeholder and iIllustration states between Cover and Image blocks
2 participants