Move editorMediaUpload to the editor module #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
gziolo
reviewed
May 10, 2018
| if ( select( 'core/editor' ) ) { | ||
| postId = select( 'core/editor' ).getCurrentPostId(); | ||
| } | ||
| const postId = select( 'core/editor' ).getCurrentPostId(); |
danielbachhuber
approved these changes
May 10, 2018
gziolo
reviewed
May 10, 2018
| @@ -8,5 +8,3 @@ | |||
| // Blocks are inferred from the HTML source of a post through a parsing mechanism | |||
| // and then stored as objects in state, from which it is then rendered for editing. | |||
| export * from './api'; | |||
|
|
|||
There was a problem hiding this comment.
@youknowriad - did you update this comment above in the PR where you migrate blocks to store? :)
There was a problem hiding this comment.
haha :) comment posted on the wrong PR
youknowriad
force-pushed
the
update/editor-media-upload
branch
from
27a3671 to
6becea0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #6275
This PR moves the editorMediaUpload helper to the editor module because it has a dependency towards the editor store. This allows us to remove the check for the store existence.
Testing instructions