Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : Hooking into command palette commands #66909

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Vrishabhsk
Copy link
Contributor

What?

  • Allows plugin to execute custom functionality before and after command palette command execution

Why?

How?

  • Create two doAction calls : commands.beforeCommandExecution & commands.afterCommandExecution
  • When these actions are hooked into, they receive the command executed as an argument in the callback

Testing Instructions

  1. Use the following snippet in a demo plugin to execute custom functionality
import { addAction } from "@wordpress/hooks";

addAction(
	"commands.beforeCommandExecution",
	"demo",
	(command) => {
		console.log(command);
	}
);

addAction(
	"commands.afterCommandExecution",
	"demo",
	(command) => {
		console.log(command);
	}
);

Screenshots or screencast

Screenshot 2024-11-11 at 5 27 06 PM

Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@afercia
Copy link
Contributor

afercia commented Nov 14, 2024

I think @WordPress/gutenberg-core can review this PR better than me. Thanks!

@afercia afercia removed their request for review November 14, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants