Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify template property behavior in InnerBlocks documentation to specify prefill when empty #66911

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Nov 11, 2024

Fixes: #64801

What?

This PR updates the docs for using Template.
The insufficiency in the docs was highlighted in this issue

Why?

Updating the wording clarifies that the template is not tied solely to the insertion event but rather to any instance where InnerBlocks lacks existing content.

Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @SeanMcMillan.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: SeanMcMillan.

Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 11, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthaknagoshe2002! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@sarthaknagoshe2002
Copy link
Contributor Author

@fabiankaegy could you please look into this PR?

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update :)

@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Dec 16, 2024
@adamsilverstein adamsilverstein merged commit cddf656 into WordPress:trunk Dec 16, 2024
65 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 16, 2024
@sarthaknagoshe2002 sarthaknagoshe2002 deleted the patch-1 branch December 16, 2024 17:23
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: InnerBlocks Templates apply whenever InnerBlocks is empty, not just on Insert
3 participants