Post fields: move date fields from edit-site to fields package
#66938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
requested review from
youknowriad,
gigitux,
louwie17,
mcsf and
ntsekouras
oandregal
commented
Nov 12, 2024
| import type { BasePost } from '../../types'; | ||
|
|
||
| const getFormattedDate = ( dateToDisplay: string | null ) => | ||
| dateI18n( |
There was a problem hiding this comment.
One interesting thing from migrating this to TypeScript is that it forces you to pass the last parameter. Despite what the docs say, there's no default value and cannot be undefined.
There was a problem hiding this comment.
I think this can be solved by slightly changing the type definition of the function and making the argument optional =something rather than something | undefined
There was a problem hiding this comment.
Reverted the default parameter and modified the JSDoc instead at 544bf3e
oandregal
commented
Nov 12, 2024
| @@ -1,5 +1,5 @@ | |||
| type PostStatus = | |||
| | 'published' | |||
| | 'publish' | |||
There was a problem hiding this comment.
This was the wrong value.
|
Size Change: +77 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 012a507. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11803354795
|
oandregal
force-pushed
the
move/date-field
branch
from
9cbcd77
to
9e44b6f
Compare
youknowriad
approved these changes
Nov 12, 2024
oandregal
force-pushed
the
move/date-field
branch
from
012a507
to
e92d04e
Compare
oandregal
commented
Nov 13, 2024
| { "path": "../data" }, | ||
| { "path": "../dataviews" }, | ||
| { "path": "../date" }, |
There was a problem hiding this comment.
Sorted alphabetically, like the package.json, and added date as a reference. A bit obscure to see, but, without this, npm run lint:tsconfig would cause the lint job to fail (see):
npm run lint:tsconfig exited with code 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the
datefield definition fromedit-siteto thefieldspackage.Why?
In preparation for moving the whole
usePostFieldshook (conversation).Testing Instructions
Visit the Pages page and verify that the "Date" field still works as expected (visualization, edit).