Place "Write mode" functionality behind a Gutenberg experiment #67008
+115
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
|
Size Change: +29 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
I want to ask if we are sure this is what we want to do, since it does not restore the previous modes. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@carolinan it's being discussed in the issue and it seems that's the case, yes. |
ntsekouras
force-pushed
the
add-write-mode-experiment-flag
branch
from
5c5a628
to
923e1d9
Compare
|
Do we need to use |
For start I'm seeking some feedback about the changes, whether I'm missing something. I'll look at the tests later and we should probably update some flags for tests in |
mcsf
reviewed
Nov 18, 2024
|
In this line we always set the mode to |
Yes, I was thinking about that, and the best way to phrase both things. |
ntsekouras
force-pushed
the
add-write-mode-experiment-flag
branch
from
923e1d9
to
e499429
Compare
Any suggestions are welcome. I wouldn't worry much for the php flag though - just the experiment label. |
ntsekouras
force-pushed
the
add-write-mode-experiment-flag
branch
from
e499429
to
ad31d5a
Compare
I have no better ideas and I'd rather just have this PR merged. This is fine. |
mcsf
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #66881