Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add link control to verse block toolbar #6706

Closed
wants to merge 1 commit into from
Closed

Enhancement: Add link control to verse block toolbar #6706

wants to merge 1 commit into from

Conversation

nfmohit
Copy link
Member

@nfmohit nfmohit commented May 11, 2018

Description

This PR addresses #6696 which requested the link control in the "Verse" block toolbar as we can see in the other blocks.

How has this been tested?

This PR has been tested by adding a "Verse" block in Gutenberg editor and locating the link control of the block in the block toolbar. It was also made sure that the link was correctly saved and rendered in the front-end. This was tested in WP 4.9.5, Gutenberg 2.8.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.

Screenshots

gutenberg-6696

Types of changes

This PR just removes the formattingControls attribute from the RichText element which specified the block to just have the bold, italic and strikethrough controls.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@noisysocks
Copy link
Member

This was removed in bd676b5 which makes me think that it's intentional that we don't support adding links to Verse. Is that right, @mtias?

@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. Needs Decision Needs a decision to be actionable or relevant labels May 29, 2018
@aduth
Copy link
Member

aduth commented Sep 13, 2018

Based on @noisysocks 's comment, I take it to be intentional that this block not support link.

@aduth aduth closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants