Fix: JavaScript error when pattern category is unregistered #67063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the wp_pattern_category taxonomy can be unregistered, it needs to be used conditionally in the JavaScript code, or there may be JavaScript errors.
|
This is a follow up to #66945 #66889 Also, while it does not break the editors in a way that make them unusable, it is not correct and a strange user experience that it is still possible to enter a custom category name during pattern creation, even if the taxonomy is unregistered. |
carolinan
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
carolinan
added
the
[Priority] Low
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mcsf
approved these changes
Nov 18, 2024
mcsf
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Because the wp_pattern_category taxonomy can be unregistered, it needs to be used conditionally in the JavaScript code, or there may be JavaScript errors.
Closes #67060
Testing Instructions
Unregister the wp_pattern_category taxonomy.
For example, copy the following to functions.php in your active theme:
Please test the following and watch for any regressions or JavaScript errors:
Repeat and create 3 more patterns:
Synced with custom category
Unsynced without category
Unsycned with custom category
Go to the pattern dataviews page (Appearance > Editor > Patterns or Appearance > Patterns depending on your theme)
Create the different patterns using the "Add New Pattern" button.
Confirm that the custom category you created when creating patterns is not listed in the sidebar with the other pattern categories.