Paragraph: Update condition for rendering Drop Cap for a selected block #67111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @briannaneiderman, @Tmeemu. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
Yes, I think this is ok personally. |
youknowriad
approved these changes
Nov 19, 2024
I will try introducing a similar test without adding another custom theme to the test suite. It will most likely be later this week; meanwhile, PR is open for feedback. |
|
I don't have time at the moment to work on e2e tests, so I'm going to merge this and handle those later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #61231.
PR prevents the typography panel from rendering with empty children without creating store subscriptions for every Paragraph block in the canvas (#56967).
Why?
The Typography panel shouldn't be rendered when a consumer disabled all options.
How?
Move
InspectorControlswithinDropCapControland only render it for the currently selected block.Note
One downside to this solution is that Drop Cap won't be available when multi-editing paragraphs. I'm not sure how often consumers actually need this.
Testing Instructions
See: #61231 (comment)
Testing Instructions for Keyboard
Same.