Query Loop block: remove 'add new post' prompt in the sidebar

[dhruvang21]

Fixes:- #67177

What?

This PR removes the "Add New Post" link in the Query Loop block's description.

Why?

The "Add New Post" link in the Query Loop block directs users to the post editor. While its intent is to guide users to create posts for an empty Query Loop block, it disrupts the user's workflow by taking them away from the editor. This leads to potential confusion as users may not know how to return and continue working on the Query Loop block. Removing the link ensures a more seamless experience.

How?

The link has been removed from the Query Loop block's description. This adjustment ensures that users are not redirected away from their current editing context.

Testing Instructions

1. Open a post or page.
2. Insert a query loop block.
3. Observe that the "Add New Post" link is no longer present in the block's description.

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <dhruvang21@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[dhruvang21]

I haven’t deleted the create-new-post-link.js file yet, as I believe removing it would require proper documentation or mentioning it in the changelog. I’m not entirely sure of the exact process, so I’d appreciate guidance from the reviewers. Once clarified, I’ll delete the file in the next commit.

[annezazu]

Just tested! Works for me.

[ntsekouras]

Thanks for the PR! If we get the consensus to remove this in the issue, we only need to remove CreateNewPostLink component in this PR and it will be ready to land.

[ntsekouras]

as I believe removing it would require proper documentation or mentioning it in the changelog.

We also need to remove this component. It's only used in Query Loop and not exported separately. No need to update anything else, like changelog or doc.

[t-hamano]

Thanks for the PR!

In addition to the CreateNewPostLink component, we should be able to remove this style as well.

Another question is whether or not to remove the BlockInfo private slot itself. This slot was introduced in #49819 but is not used except in the Query Loop block.

cc @aaronrobertshaw

[aaronrobertshaw]

Thanks for the PR @dhruvang21 and the ping @t-hamano 👍

I'm definitely on board with removing not only the link but the component and private SlotFill as well.

#49819 was to maintain the existing UI when the block inspector tabs were introduced but it should also provide a loose guide on what needs to removed. As others have noted, this includes:

• CSS styles for the create new post link
• CreateNewPostLink component
• BlockInfo private SlotFill, its use, and private APIs export

The createPrivateSlotFill util was also recently removed.

[ntsekouras]

@dhruvang21 let's also remove the BlockInfo private slot and it would be ready to land. Thank you!

[ntsekouras]

Can you rebase because of the conflicts?

In order to properly remove the BlockInfo slot we need to:

1. remove the file as you already did
2. remove the private export here (import and lock)
3. remove from block inspector (import and usage)

[dhruvang21]

Can you rebase because of the conflicts?

In order to properly remove the BlockInfo slot we need to:

1. remove the file as you already did
2. remove the private export here (import and lock)
3. remove from block inspector (import and usage)

Thank you for guiding me! I’ve rebased the branch and resolved the conflict. Please have a look.

[ntsekouras]

Looks good, thank you!